[MERGE] Fix log --limit (broken by log filtering patch).

[Robert Collins]

On Sun, 2008-09-07 at 19:25 -0600, Scott Scriven wrote:
> > I chose not to include the other test; it was faulty - it didn't
> check
> > what was actually returned, and it did much more work than needed.
> 
> The extra work was actually intentional.  I know how many 
> revisions the iterator returns in the first batch, but the test 
> shouldn't, so I set the number of revisions high enough to handle 
> changes in the iterator's implementation.  As is, increasing the 
> batch size could produce misleading test results.

The problem is, there is no limit high enough to ensure that this can't
happen - you need a infinite count :P. So the test and the code are
coupled; best to then either accept the possibility of skew, or make the
coupling explicit somehow.

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080908/d77b3c70/attachment.pgp