[MERGE] Fix log --limit (broken by log filtering patch).
Scott Scriven
bzr at toykeeper.net
Mon Sep 8 02:25:17 BST 2008
* Robert Collins <robertc at robertcollins.net> wrote:
> > I agree your method seems a bit better than the "double
> > break" form.
Definitely. I'm surprised I didn't notice the 'break' was at the
end of a function.
> > Both have tests for this, we may want to include both.
>
> I chose not to include the other test; it was faulty - it didn't check
> what was actually returned, and it did much more work than needed.
The extra work was actually intentional. I know how many
revisions the iterator returns in the first batch, but the test
shouldn't, so I set the number of revisions high enough to handle
changes in the iterator's implementation. As is, increasing the
batch size could produce misleading test results.
-- Scott
More information about the bazaar
mailing list