[MERGE] add win32utils.get_local_appdata_location()

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aaron Bentley wrote:
> Mark Hammond wrote:
>> I've been confused about this in the past, and last time I asked I was told
>> that tweak *does* mean I need to resubmit
>> (http://thread.gmane.org/gmane.comp.version-control.bazaar-ng.general/41091/
>> focus=41837)
> 
>> The developers guide is also vague on this - it mentions another review
>> isn't necessary, but doesn't explicitly say who should apply the tweaks.
> 
> The original author is usually expected to make the changes.  If they
> have PQM rights, then they can just make the changes and submit it to
> PQM.  Otherwise, they need to get the changed version to someone who
> does have PQM rights.
> 
> Aaron

So... Author's can always rework their patches to get things merged. I think
using:

:resubmit
  Author *must* rework the patch and resubmit for review
:tweak
  Patch needs rework, but it is trivial enough for the submitter to do so

In the case of devs with PQM access, submitter == author, so it is the same
system we have now. For people without access, we don't *have* to do another
round trip to get it merged. If an author want's to do the changes, it may
speed up the process. Though I find when things get resubmitted, it throws
some amount of flux into the system. You may need to re-review the patch to
make sure the comments were addressed, you at least lose the original votes
and discussion on the earlier patch, etc. (I don't have empirical evidence,
but I would offer that sometimes resubmitting actually slows down the final
merge, because of human inefficiencies.)


In the specific case Mark is referencing, there was a distinct layering issue.
Specifically, I felt that Ian had proposed some changes that he wanted Mark to
comment on. He also had submitted it as a delta against Mark's patch, rather
than as a combined diff. So I didn't strictly feel comfortable merging the two
together without at least Mark commenting on it.

Perhaps it would have been as straightforward to vote :resubmit and ask Mark
to apply Ian's changes. Certainly I felt like the requested changes were not
the trivial kind that I would consider :tweak.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIwYBWJdeBCYSNAAMRAhjnAJ4id3vv1u9XV6G0Ld8g2rX3cs2mrQCeP2Rs
5UPUu/6VdtO1vwvTWY9KB2I=
=sCX2
-----END PGP SIGNATURE-----