[MERGE] Improved review process docs and separate out architectural overview

Martin Pool mbp at sourcefrog.net
Fri Sep 5 01:45:11 BST 2008


On Thu, Sep 4, 2008 at 6:58 PM, Vincent Ladeuil <v.ladeuil+lp at free.fr> wrote:
>>>>>> "martin" == Martin Pool <mbp at sourcefrog.net> writes:
>
> <snip/>
>    martin> === modified file 'doc/developers/HACKING.txt'
>    martin> --- doc/developers/HACKING.txt      2008-08-20 02:07:36 +0000
>    martin> +++ doc/developers/HACKING.txt      2008-09-04 04:55:36 +0000
>
> <snip/>
>    martin> +Checklist for reviewers
>    martin> +=======================
>    martin> +
>    martin> +* Do you understand what the code's doing and why?
>    martin> +
>
> * Does the change meet the requirements listed above (test coverage,
>  design clarity, improvements, etc).

Good point.

> <snip/>
>    martin> -
>    martin> -TODO: Incorporate John Arbash Meinel's detailed email to Ian C on the
>    martin> -numerous ways of setting up integration branches.
>
> Was this deletion intended ? If yes, do you still have a copy of
> this mail ? ;)

I probably do but this comment didn't give me enough information to
easily find it.  I don't think anything is particularly missing here -
as far as I know you do the review either by reading the diff or
trying the merge.  If someone wants to add it they can do that later.

-- 
Martin <http://launchpad.net/~mbp/>



More information about the bazaar mailing list