"bzr log --limit" broken since r3652

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Teemu Likonen wrote:
> The merge commit
> 
>     r3652 pqm at pqm.ubuntu.com-20080828023029-r2qwgt7zu9udtla3
>     (robertc) Permit filtering of log output by plugins. (Robert 
>     Collins)
> 
> broke the --limit option of bzr log, for me at least. Now with --limit 
> it displays what seems to be a random set of commits. For example "bzr 
> log --limit 3 --line" prints this:
> 
>     3668: Canonical.com Pat... 2008-08-30 (vila) Add test prefix aliases 
>     for selftest --starting-with
>     3667: Canonical.com Pat... 2008-08-29 (jam) Merge bzr-1.6.1rc1
>     3666: Canonical.com Pat... 2008-08-29 (vila) Really fix bug #2...

Yeah, Robert said he was going to work on fixing that, I'm not sure where he
got to.

Basically, it is an unexpected interaction. We have one bit of code that
breaks up requests into smaller bits (say you have 10,000 revisions, it breaks
it up into increasing amounts, 9, 13, 20, 31, etc).
And what seems to be happening is that the '--limit' parameter is being
evaluated at each level. So you get the first 3 of the first 9, the next 3 of
the next 13, etc.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIuqD+JdeBCYSNAAMRAtV6AJ4up5mj1PZF+8HQ/G/+131SQZqngQCfTpT3
ahsY+WhnE+KXlo9VPM3hC1s=
=T2Li
-----END PGP SIGNATURE-----