Email Hooks

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Aaron Bentley wrote:
> Russel Winder wrote:
>> Is there any way of testing the email hook stuff?  Is it obvious what I
>> am doing wrong?
> 
> Perhaps what you are doing wrong is configuring it on the server, not
> the client?
> 
> Aaron

Well, I think there is a disconnect between what Russel is looking to do, and
what things were designed around...

bzr-email was designed (originally) as a strictly client-side option for
sending an email when you run "bzr commit". To let people know that you have
changed something.

In some ways, it works better as a client-side functionality, because users
are never required to commit back to a server. bzr is perfectly capable of
copying from a server, and then committing locally. And without the client
configured to send an email, nobody else has the opportunity.

That said, we certainly allow pushing back to a server, and there have
certainly been user requests for sending emails when changes show up on the
server.

I thought someone had configured bzr-email to hook into the new
"post_change_branch_tip" hook (available in 1.6). Which *would* trigger every
time the branch was pushed/updated/committed/uncommitted.

There are still questions, though. For example when you push 20 changes to a
branch, do you want to send 20 emails, or just 1?

What about if it is a bunch of merges? So there are 5 tip revisions pushed,
but 500 merged revisions?

If the merged revisions are in another branch that have already had the email
sent, do you want to not send an email for them?

I think the easiest thing is to just send a single "combined" email which has
the log of all new revisions. But it is something that reasonable people may
disagree on. So we need at least some discussion to define what happens.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFItAmDJdeBCYSNAAMRAqATAKDBYheEG3kyfPe7yS5Tzz16H8IBDwCgsP7H
zLvimkkjmhYdZGuNYYj8668=
=BUaj
-----END PGP SIGNATURE-----