[MERGE] (robertc) Cap the amount of data we write in a single IO during local path pack operations to fix bug 255656. (Robert Collins)

[Robert Collins]

On Thu, 2008-08-14 at 23:08 -0500, John Arbash Meinel wrote:


> This at least feels like it should be a helper function akin to
> "osutils.pumpfile".

Ok, I"ll put one [tested] together.

> BB:tweak
> 
> The actual loop seems fine, though I would wonder about buffer() versus
> just bytes[start:end]. (I realize there is at least 1 copy in using
> slicing, but I also don't think we need to be using a 5MB buffer here.)

bytes[start:end] does a memcpy. buffer does not.

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080815/93a22e0f/attachment-0001.pgp