[MERGE] (robertc) Cap the amount of data we write in a single IO during local path pack operations to fix bug 255656. (Robert Collins)

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> This fixes a bug in autopack with windows & SMB mounted drives.
> 
> Simply, the file.write(bytes) call was failing when bytes was 80MB in
> size.
> 
> No explicit test for this, but I can shelve it and come back later if
> needed.
> 
> -Rob
> 
> 
> 

This at least feels like it should be a helper function akin to
"osutils.pumpfile".

BB:tweak

The actual loop seems fine, though I would wonder about buffer() versus
just bytes[start:end]. (I realize there is at least 1 copy in using
slicing, but I also don't think we need to be using a 5MB buffer here.)

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkilATkACgkQJdeBCYSNAAMFnQCgsu1BAeOj3g5ESqCEEj9EXCZc
yr0An35IxkmX65fkd6B/QbushSF3t1hy
=F7+8
-----END PGP SIGNATURE-----