[MERGE] Improve tests for the behaviour of Tree.iter_changes for missing paths that are only present in one tree, and fix found bugs. (Robert Collins)

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> On Wed, 2008-08-13 at 21:52 -0500, John Arbash Meinel wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Andrew Bennetts wrote:
>>> Robert Collins wrote:
>>>> On Wed, 2008-08-13 at 09:17 -0500, John Arbash Meinel wrote:
>>> [...]
>>>>> BB:tweak
>>>>>
>>>>> I agree with Andrew about raising TestNotApplicable, even though it
>>>>> isn't your preference, it *is* the recommended way of doing it in the
>>>>> test suite.
>>>> How about:
>>>>  - I raise a bug saying that: our test parameterisation generates too
>>>> many tests, we need a easy way of having some permutations getting
>>>> opted-out (and that when that is done TNA gets deleted)
>>>>  - I raise TNA
>>> I'm ok with this course of action.  (Although I'm not at all sure that *all*
>>> uses of TNA will be better if replaced with more complicated parameterisation,
>>> I'm happy to explore the possibility.)
>>>
>>> In the meantime, TNA is the best we've got (better than a bare return).
>>>
>>> -Andrew.
>>>
>>>
>> I *do* think that TNA is the best we have right now. It unwinds the stack, so
>> means you don't have to write:
> 
>> But, badly written tests will get written, and they just need to be
>> fixed.
>>
>> John
> 
> So we've got conflicting opinions here. Neither of you have updated
> beyond 'tweak', so AFAICT we're still discussing the tweak. John, are
> you against my proposal (use TNA, file a bug) specifically, or in
> general saying you think the bug will not be enough to eventually remove
> the use of TNA (which may be the case, but I'm happy to cross that
> bridge if we reach it).
> 
> Roob
> 

I've just been participating in the thread having approved "use TNA, and file
a bug". (Considering my tweak only required use TNA, you can do what you want
with bugs).

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIo6IUJdeBCYSNAAMRAjM5AJ972OrDoweQnonJOp2Q6xhUd6jMSwCfazxA
h0/ELzdRPunyjDfoaDW1Qa8=
=zVbn
-----END PGP SIGNATURE-----