1.6 home straight

[Adrian Wilkins]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote

> * I believe there is a Windows-specific fix (?) which does not have
1.6 in the subject but wants to be merged across.

I think this is referring to

http://bundlebuggy.aaronbentley.com/project/bzr/request/%3C489ACEB7.1010503%40gmail.com%3E

Introduced by
revid:robertc at robertcollins.net-20080730095022-4tc7ij34c0tmejb5



John Arbash Meinel wrote:
>I think this is actually the wrong fix. There are comments and codepaths in the
> osutils.py code that make it clear "walkdirs(file)" should not be an error.

>            try:
                      names = sorted(_listdir(top))
              except OSError, e:
                      if getattr(e, 'errno', None) == errno.ENOTDIR:
                              # We have been asked to examine a file, this is fine.
                              pass
                      else:
                              raise


On the subject of this piece of code ; I would expect it to be far more costly
to deal with an exception than it is to check that `file` is a directory in the
first place. Am I just thinking with Java/C# coloured synapses?


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIoq7bcP1uebIhWSYRAlVuAJ43hloR4ORIJAJN9+NhGNIaMj921ACbBQZD
1Dq56hFDQF467Gq46ZS1z6A=
=SvHk
-----END PGP SIGNATURE-----