[MERGE] Review feedback : test for PointlessCommit and that the example given in the help (excluding a subtree of a specified tree) does in fact work.

[Robert Collins]

On Tue, 2008-08-05 at 12:55 +1000, Andrew Bennetts wrote:
> 
> > It's explicitly covered by subtree_of_selected.
> 
> That test is explicitly about excluding subtrees, not about -x taking
> precedence
> over a specifically included path.  Implementation-wise the tests
> would likely
> be very similar, but I think ideally unit tests ought to have a single
> clear
> purpose.  There's a risk (probably quite small in this case, so I'm
> not too
> worried) that a future refactoring of the test code would fail to
> notice the
> dual-purpose of this test and so inadvertently reduce test coverage.

I'm totally confused here. IRC perhaps?


-Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080805/891f1672/attachment.pgp