[MERGE] Review feedback : test for PointlessCommit and that the example given in the help (excluding a subtree of a specified tree) does in fact work.

[Robert Collins]

On Mon, 2008-08-04 at 17:59 -0500, John Arbash Meinel wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Robert Collins wrote:
> | Thanks for the feedback James,
> | addressed herewith.
> |
> | -Rob
> |
> 
> - -        specific_files = self.specific_files
> +        exclude = self.exclude
> +        specific_files = self.specific_files or []
> 
> 
> ^- I believe "iter_entries_by_dir()" considered special_files = [] to
> mean include *no* files, rather than all files. But I guess you are only
> using that as a local variable to pass to is_inside_any.

Yes, is it worth adding a comment? seems low risk to me, misuse of it
will break tests all over immediately.

-Rob


-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080805/286bdf31/attachment.pgp