[MERGE] Review feedback : test for PointlessCommit and that the example given in the help (excluding a subtree of a specified tree) does in fact work.

John Arbash Meinel john at arbash-meinel.com
Mon Aug 4 23:59:25 BST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
| Thanks for the feedback James,
| addressed herewith.
|
| -Rob
|

- -        specific_files = self.specific_files
+        exclude = self.exclude
+        specific_files = self.specific_files or []


^- I believe "iter_entries_by_dir()" considered special_files = [] to
mean include *no* files, rather than all files. But I guess you are only
using that as a local variable to pass to is_inside_any.

Otherwise it seems fine.

BB:approve

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkiXic0ACgkQJdeBCYSNAAP8KACfeLoMpICTUrZp40AtsvrfMv2g
GZYAnRBh4YeRS76+qUxdL7U+tuRMjHTR
=z0Xo
-----END PGP SIGNATURE-----



More information about the bazaar mailing list