[MERGE] Teach GenericRepoFetcher to handle revisions/sigs properly

[Robert Collins]

On Fri, 2008-07-25 at 21:29 -0500, John Arbash Meinel wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> The GenericRepoFetcher already is using data streams to logically handle
> inventories and file texts. However, it was currently requesting
> signatures and revisions 1-at-a-time.
> 
> The only reason I can think of for it to do so is because it doesn't
> want to insert a signature that doesn't have an associated revision,
> though why not just insert the revisions first then...

Actually the other ordering is needed: signatures before revisions,
because signatures are not copied once the revision is.

One possible reason for using the public api to fetch revisions is to
allow updates of the inventory sha pointer, but that shouldn't be
happening for SameModel fetches anyway.

...
> However, we've also run into problems that ^C after fetching the
> signature will cause a future fetch to fail. Because it doesn't think it
> has the signature, goes to insert it...

This should be fixed with VersionedFiles behaviour anyway.

> Anyway, this is enough of a performance win for inter-repository
> fetching, that I think it is worthwhile.

We should try to avoid the full [de]serialisation thats true.

Your bundle seems to have been against an old trunk or something, so
perhaps you could regenerate it with less noise?


-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080728/9ad7f79f/attachment.pgp