[MERGE] [RFC] Add VirtualSignatureTexts

[Jelmer Vernooij]

Am Montag, den 28.07.2008, 06:28 +1200 schrieb Aaron Bentley:
> Jelmer Vernooij wrote:
> > The attached patch adds a VirtualSignatureTexts class, that is used by
> > both bzr-svn and bzr-git.
> Why does this need a particular class?  VirtualVersionedFiles provides
> the right amount of abstraction, IMHO.  You can just implement get_lines
> on it.
This common implementation is required by both bzr-svn and bzr-git.

> And I also think that this is layered badly.  Repositories are meant to
> be provided on top of VersionedFiles, so implementing VersionedFiles on
> top of Repository is a recursive definition.
That's the only thing that's possible on non-native repositories. Bazaar
assumes a repository to be able to implement the VersionedFiles API for
revisions, inventories and signatures but those files have to be
generated on-the-fly for non-native repositories.

Cheers,

Jelmer
-- 
Jelmer Vernooij <jelmer at samba.org> - http://samba.org/~jelmer/
Jabber: jelmer at jabber.fsfe.org