[MERGE] [RFC] Add VirtualSignatureTexts

Aaron Bentley aaron at aaronbentley.com
Sun Jul 27 19:28:08 BST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jelmer Vernooij wrote:
> The attached patch adds a VirtualSignatureTexts class, that is used by
> both bzr-svn and bzr-git.

Why does this need a particular class?  VirtualVersionedFiles provides
the right amount of abstraction, IMHO.  You can just implement get_lines
on it.

And I also think that this is layered badly.  Repositories are meant to
be provided on top of VersionedFiles, so implementing VersionedFiles on
top of Repository is a recursive definition.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIjL440F+nu1YWqI0RAn4TAJ9D4zKY4BAxbiIIkPrBEaiB57Dh1gCggDRU
ag1xP9YkvVZM/fHrxHPJ9Rc=
=5gck
-----END PGP SIGNATURE-----



More information about the bazaar mailing list