[MERGE] Switch nick too

[Marius Kruger]

2008/7/23 John Arbash Meinel <john at arbash-meinel.com>

> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Matthew D. Fuller wrote:
> > On Wed, Jul 23, 2008 at 12:21:33PM +1000 I heard the voice of
> > Rob Weir, and lo! it spake thus:
> >> On 21 Jul 2008, Marius Kruger wrote:
> >>> I've been using `bzr switch` a bit recently, and I'm thinking it
> >>> will be nice if it will update the branch's nick too to be the
> >>> nick of the new branch we're binding to.  It makes sense if you
> >>> use a checkout as a working branch and switch between other local
> >>> branches for current work.
> >> Great - lightweight checkouts already work like this, so it would be
> >> good to make regular ones consistent.
> >
> > Even more consistent would be if they properly set the nick on the
> > initial checkout too.
> >
> >
>
> Or just always returned the nick of the master branch, if that is what we
> really want. Then you wouldn't have to hack around it in every command that
> might do something to effect the nick.
>
> Simply (psuedocode)
>
>
> def _get_nick(self):
>  master = self.get_master_branch()
>  if master is None:
>    # return the local value
>    config = self.get_config()
>  else:
>    config = master.get_config()
>  return config.get_nick()
>

I dont like the idea of checkouts dynamically using the masters' nick, since
for checkouts you might want to change the nick.
But when you use switch, you generally want it to look like youre actually
working directly on the master branch,
but still having the option of changing it if you like.

I attached the patch with the bug number in the news.

regards
marius
-------------- next part --------------
An HTML attachment was scrubbed...
URL: https://lists.ubuntu.com/archives/bazaar/attachments/20080726/b2d50a83/attachment.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: switch_nick3.patch
Type: text/x-patch
Size: 7069 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080726/b2d50a83/attachment.bin