[MERGE] whitespace normalization

[Benjamin Peterson]

On Thu, Jul 24, 2008 at 6:00 PM, Ian Clatworthy <
ian.clatworthy at canonical.com> wrote:

> Benjamin Peterson wrote:
> > I ran reindent.py (from the main Python distribution) on all the Bazaar
> > sources. The resulting bundle was too large for the list so please see
> > the public branch at
> > http://code.launchpad.net/~musiccomposition/bzr/reindent<http://code.launchpad.net/%7Emusiccomposition/bzr/reindent>
> > <http://code.launchpad.net/%7Emusiccomposition/bzr/reindent>
>
> I see that Aaron has rejected this on the basis that it introduces
> spurious conflicts. I understand his point.
>
> I'm not sure tuning indents is all that necessary/useful. I read
> lots of Bazaar's code while reviewing and I actually think humans
> do a better job of deciding where to break lines myself.


Of course, it's not a big deal to me. It's just that my emacs trailing
whitespace hook was going wild. In the Python core, we have a commit hook
that rejects commits with trailing whitespace. Maybe this is something
Bazaar-dev could do in the future?

>
>
> OTOH, I would support and approve one or more patches that stripped
> trailing whitespace off lines. It's off absolutely no value IMO and
> ought to go. I actually started putting together a patch to do this
> months ago but it was huge - there's lot of this cruft in there.


If I get the time, I could probably modify reindent.py to just strip the
trailing whitespace.

>
>
> Ian C.
>



-- 
Cheers,
Benjamin Peterson
"There's no place like 127.0.0.1."
-------------- next part --------------
An HTML attachment was scrubbed...
URL: https://lists.ubuntu.com/archives/bazaar/attachments/20080724/2a819156/attachment.htm