[RFC] Fix Bug #220331
John Arbash Meinel
john at arbash-meinel.com
Fri Jul 11 14:36:28 BST 2008
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Audrius Kažukauskas wrote:
| Hello,
|
| I fixed bug #220331. Could you please take a look at the fix?
|
|
Hi-
Thanks for working on this. I would recommend using [MERGE] in your
email. I realize you may not be sure if it is fully ready to merge, but
by doing so your patch gets tracked by Bundle Buggy. Which makes it less
likely to get lost.
I'm very happy to see that you wrote a test of the functionality. I
think Daniel Watkins pointed out a few ways to make the tests better. I
would also just hint that the test suite runs on multiple platforms and
'/tmp' is not always the best directory.
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iEYEARECAAYFAkh3YdwACgkQJdeBCYSNAAMTVACfdkHvRDiqApFIC/hC4uLXZ02i
5VAAoJiTzR8Q7rA60GpQ6GOOkDPZ6ZAP
=kz+n
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list