[MERGE] Add credits command and --show-class option

Ben Finney bignose+hates-spam at benfinney.id.au
Thu Jul 3 01:39:18 BST 2008


Jelmer Vernooij <jelmer at samba.org> writes:

> It adds a credits command and a --show-class option to the stats
> command. E.g. for bzr-stats itself:
> 
> ganieda:~/bzr-gtk/credits% bzr stats --show-class ~/bzr-stats/trunk
> getting ancestry
> getting revisions
>   13 John Arbash Meinel <john at arbash-meinel.com>
>      Contributions:
>         6% Unknown
>        94% code
>   12 Jelmer Vernooij <jelmer at samba.org>
>      Contributions:
>       100% code
>    1 Wesley J. Landaker <wjlanda at sandia.gov>
>      Contributions:
>       100% code

The name '--show-class' doesn't suggest this behaviour. Why was that
name chosen?

I would expect this behaviour to have an option named, e.g.,
'--show-contribs'.

> ganieda:~/bzr-gtk/credits% bzr credits ~/bzr-stats/trunk
> Code:
> Jelmer Vernooij <jelmer at samba.org>
> John Arbash Meinel <john at arbash-meinel.com>
> Wesley J. Landaker <wjlanda at sandia.gov>

This option is well-named and appears well-implemented.

A minor tweak: Please make the output slightly more machine-parseable,
by making a simple distinction between the type of contribution
("Code:") and the committer. Perhaps by indenting the committer lines:

=====
ganieda:~/bzr-gtk/credits% bzr credits ~/bzr-stats/trunk
code:
  Jelmer Vernooij <jelmer at samba.org>
  John Arbash Meinel <john at arbash-meinel.com>
  Wesley J. Landaker <wjlanda at sandia.gov>
=====

This would then be consistent with other output, like 'bzr status'.

-- 
 \            “There are always those who think they know what is your |
  `\          responsibility better than you do.” —Ralph Waldo Emerson |
_o__)                                                                  |
Ben Finney




More information about the bazaar mailing list