[pqm/MERGE/pqm] Switch to distutils

Jelmer Vernooij jelmer at samba.org
Tue Jul 1 12:15:55 BST 2008


On Tue, Jul 01, 2008 at 01:27:56PM +1000, Martin Pool wrote:
> I don't know if Robert thinks changing from autofoo to distutils is an
> improvement.  I think it is.

> +                raise SystemExit, "Unable to find 'xmlto', needed to
> generate Docbook HTML documentation."

> bzr's style guide says this should be SystemExit(blah), and I think
> the old syntax is deprecated or will be in Python.

> +    author="Colin Walters",
> +    author_email="walters at debian.org",
> +

> Should that be changed?  From memory there is a distutils field for
> "current maintainer" as opposed to "original author".

> Aside from that it looks ok to me.
Thanks for the review! Fixed in the attached patch.

Cheers,

Jelmer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pqm-distutils.patch
Type: text/x-diff
Size: 19045 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080701/0725be4d/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 315 bytes
Desc: Digital signature
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080701/0725be4d/attachment.pgp 


More information about the bazaar mailing list