[MERGE] repository external reference tests (StackedBranches)

John Arbash Meinel john at arbash-meinel.com
Wed Jun 11 14:05:39 BST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Vincent Ladeuil wrote:
|>>>>> "martin" == Martin Pool <mbp at canonical.com> writes:
|
|     martin> On Wed, Jun 11, 2008 at 2:35 PM, Robert Collins
|     martin> <robertc at robertcollins.net> wrote:
|     >> On Wed, 2008-06-11 at 13:09 +1000, Martin Pool wrote:
|     >>> At Ian's request I'm going to do these tweaks and submit it.
|     >>>
|     >>> I'm going to rename the module to per_repository_reference which is
|     >>> consistent with at least per_lock and much more wieldy.
|     >>
|     >> Its inconsistent with all the *_implementations ones though. Can we pick
|     >> one standard and use it? I don't care which.
|
|     martin> My vote is for "per_*" then; it's shorter and imo conveys the most
|     martin> important information which is that they're multiplied tests.
|
| +1 for the same resaons
|
|    Vincent
|
|

Agreed.

Of course, now we need to decide if it is worth renaming everything just for
this? We certainly don't have a history of large "cleanup" changes. (All of the
"from ... import" lines need to change, etc.)

As it is is the test suite, I think it is okay, though.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.9 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iEYEARECAAYFAkhPzaMACgkQJdeBCYSNAAP3LACeMQn4punGykk8iz8NHJs4MM6r
inkAnikKbuuuB+m2XGAHni8cqS/z34it
=7mA/
-----END PGP SIGNATURE-----



More information about the bazaar mailing list