[MERGE] Sanitize branch nick before using it as an attachment filename in ``bzr send``
Aaron Bentley
aaron at aaronbentley.com
Fri May 23 23:48:08 BST 2008
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Lukáš Lalinský wrote:
> Hi,
>
> I was bitten by this bug - https://bugs.launchpad.net/bzr/+bug/210218 -
> today, although in a bit different form. I had a branch nick with < and
>> characters in it, but none of \"*/:<>?| is not allowed in filenames on
> Windows. This patch replaces all "non-word" characters with -.
bb:approve
This feels a bit too strict to me. I'd rather see spaces and
punctuation permitted. In fact, I'd rather see a blacklist than a
whitelist.
Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFIN0mo0F+nu1YWqI0RAvRnAJ4rDR2lvgkNRfaDX1QgXZYIaxoh9gCfaGpC
rSa+seN9FWdX2msg/3OrKb0=
=vTQM
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list