[1.5 critical] Branch.lock() does not set RemoteRepository.is_locked() == True

[Russ Brown]

John Arbash Meinel wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> I'm investigating this now, but I just ran into a *really* weird bug. 
> Basically
> if you do:
> 
> |>> b = bzrlib.branch.Branch.open('bzr+ssh://....')
> |>> b.lock_read()
> |>> print b.is_locked(), b.repository.is_locked()
> True, False
> 
> I'm trying to track down why, but it seems to be causing some 
> performance issues
> with remote operations that are using get_parent_map(). Because if the 
> remote
> repo doesn't think it is locked, it will not cache any of the requests. And
> other stuff just plain breaks (bzr log --short bzr+ssh://, fails during
> iter_reverse_revision_history() because it thinks the repo isn't locked.)
> 

In case it helps, I can reproduce this behaviour using 1.4 on both 
client and server.

> 
> I'm not going to put out 1.5rc1 unless I can fix this, so stay tuned.
> 
> John
> =:->
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.9 (Cygwin)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
> 
> iEYEARECAAYFAkgkgJUACgkQJdeBCYSNAAOSJgCgl//w91ARoTKZVq8kDvkAR+mm
> MS4AoL7TynjLBMT39JgLXBvgUrl6BL1M
> =4ued
> -----END PGP SIGNATURE-----
>