[MERGE] Fix fetch all on pack repositories (#212908)

Aaron Bentley aaron at aaronbentley.com
Fri Apr 25 23:39:59 BST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi all,

I recently discovered that invoking fetch with no arguments when the
source repository has identical contents to the target repository can
cause a pack naming collision.  This is because although you'd expect it
to be a no-op, fetch actually creates a new pack with the same contents
as the repository already has.  And two packs with the same contents
have the same name.

This patch is a test by me and a fix by Robert Collins.  I've also
removed the workarounds that I implemented for this bug.

It doesn't solve bug #165293, the general case, but it makes fetch all
only fetch new data, so it fixes #212908.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFIEl2/0F+nu1YWqI0RArHgAJ4lF6qetQFY26EXTHUL4CDTIb5wkQCfYJfc
jc2fFdrwbvji5anT6cVfN3M=
=KQyG
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-212908.patch
Type: text/x-diff
Size: 6398 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080425/aa287bbb/attachment-0002.bin 


More information about the bazaar mailing list