[BzrTools/MERGE] cdiff --check-style Highlight trailing white space
Aaron Bentley
aaron.bentley at utoronto.ca
Sat Apr 26 18:29:18 BST 2008
Marius Kruger wrote:
> On Wed, Jan 17, 2007 at 6:48 PM, Aaron Bentley
> Apparently, we also need "Contains leading tabs" :-)
>
>
> done
> I realise it was a bit of a joke, but I did it any ways as it might
> obviously be useful.
> It also gives a summary of new lines containing tabs (if any).
Thanks.
> I like the idea, but I don't like having two different tests for
> trailing whitespace. Don't Repeat Yourself, as Martin recently
> reminded me.
>
>
> I tried to do this better,
> but that forced me to send the match object to colorstring(), or pass
> the components seperately.
> The colorstring() is not a nice api any more, so I was thinking
> to change mine to _colorstring() and bring back the original one (for in
> case someone used it elsewhere).
I can live with it. The important thing to me is that we don't
duplicate fuctionality. Maybe we can refactor in the future.
> > We can also highlight text which is over 79 chars...
> > what do you think?
>
> David Allouche actually had a neat one for this. Instead of "trailing
> whitespace" or "under 80 chars", he did "wraps idempotently".
>
>
> I'm not sure what you mean by "wraps idempotently",
> but my new version highlight long lines nicely.
"Wraps idempotently" meant "if you apply TextWrap to it, the output is
the same as the input."
I've applied your patch. Thanks.
Aaron
More information about the bazaar
mailing list