[MERGE] "bzr commit" fails with Microsoft FTP Service

Aaron Bentley aaron at aaronbentley.com
Fri Apr 11 15:18:10 BST 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Andreas Deininger wrote:
> 2008/4/9 John Arbash Meinel <john at arbash-meinel.com>:
> After putting a the check for 550 in the _rename function, I'm
> resubmitting that patch.

bb:resubmit

550 doesn't have a well defined meaning in the context of a rename.  It
could mean "file does not exist" or "new name could not be created"
(because ftplib's rename does RNFR and RNTO, and either can fail with
550, and you can't tell which it was from the exception).

So please don't delete the vsftpd handling, and do the 550 check after
trying _translate_perm_error.  That way, well-known servers will work
well, and other servers will kindof work.

And do startswith('550 '), so you know the number stops there.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFH/3Mi0F+nu1YWqI0RAn+kAJ4oXIf3UBKAzxuOccScdJfK47deLQCfalax
iRohVaYHzwhT6FNWOIvSpkU=
=lCE0
-----END PGP SIGNATURE-----



More information about the bazaar mailing list