[MERGE] Enable setting and getting make_working_trees for all repositories

Robert Collins robertc at robertcollins.net
Thu Apr 10 03:50:17 BST 2008


On Wed, 2008-04-09 at 22:41 -0400, Aaron Bentley wrote:
> 
> > For that matter, I don't really
> > understand how this is a significant improvement over raising
> > NotImplementedError.
> 
> NotImplementedError usually means someone forgot to implement
> something.
>       I think that kind of error should trigger a test suite failure.
> 
> ValueError means that the supplied value was unsuitable, and for
> AllInOne repositories, False is not a usable value.  (True is, because
> that's the value they always use.)

We use NotImplementedError pervasively in bzrlib for 'optional method
that this class does not implement'. Changing that as a standard should
have at least *some* discussion.

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080410/7dffa808/attachment.pgp 


More information about the bazaar mailing list