[MERGE] Enable setting and getting make_working_trees for all repositories

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Andrew Bennetts wrote:
> Aaron Bentley wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Hi all,
>>
>> This patch enables set_make_working_trees on all repository
>> implementations.  For repository implementations where it cannot be
>> changed, it raise ValueError if called with "False".
> 
> I don't like using ValueError for this.

I can do a custom error, then.

> For that matter, I don't really
> understand how this is a significant improvement over raising
> NotImplementedError.

NotImplementedError usually means someone forgot to implement something.
      I think that kind of error should trigger a test suite failure.

ValueError means that the supplied value was unsuitable, and for
AllInOne repositories, False is not a usable value.  (True is, because
that's the value they always use.)

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFH/X5I0F+nu1YWqI0RArdiAJ9fy1CA2A1MiI1yTL0aBz6SxxCOHwCfffyW
lvP94Gtz6+UO4jcHsLQVwzo=
=6v35
-----END PGP SIGNATURE-----