[MERGE] Remove manual notification of transaction finishing on versioned files.

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
| This removes the manual notification need for versioned files, replacing
| it with a callback to an arbitrary function; this allows VersionedFiles
| to stop tracking 'open' weaves, which will reduce memory pressure when
| the use of the api is cleaned up - coming soon :P.
|
| Oh, completely api incompatible.
|
| -Rob'
|

Aren't you preserving at least some api compatibility with the 'make_file_knit'
helper function?

I think it would be nice to at least mention the api break in NEWS more obviously.

I find it very interesting that you need to do this:
- -    _matching_file_to_factory = KnitVersionedFile
+    _matching_file_to_factory = staticmethod(make_file_knit)


^- If you have a Class it seems python leaves it as an object, but if you have a
function, python tries to make it a member function rather than assuming it is
static.

Anyway, I'm glad you got it to work, even if it is a bit odd. Perhaps a comment
here since people probably won't expect it? (I know I ran into it elsewhere a
while ago, and wasn't sure how to fix it.)


I won't say that I followed every line 100%, but the patch generally looks good.

BB:tweak

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFH/HwHJdeBCYSNAAMRAuQFAJ9ut4dgsu2duQNC0R9aPqyIj09urwCeJy7z
miAgWZkg+CFfYbNrzsGYqyo=
=JgrB
-----END PGP SIGNATURE-----