[MERGE] Command Not Found core code

Martin Albisetti argentina at gmail.com
Fri Apr 4 02:12:37 BST 2008


On Thu, Mar 13, 2008 at 5:35 PM, Ian Clatworthy
<ian.clatworthy at internode.on.net> wrote:
>  bb:tweak
>
>
>  > +        else:
>  > +            raise errors.CommandAvailableInPlugin(cmd_name, plugin_metadata, provider)
>
>  This line is over 80 chars so needs to be wrapped.
>
>  > +class ProvidersRegistry(registry.Registry):
>  > +    '''This registry exists to allow other providers to exist'''
>  > +    def __iter__(self):
>  > +        for key, provider in self.iteritems():
>  > +            yield provider
>  > +    pass
>
>  Blank line needed between the class docstring and the first method.
>  The 'pass' line ought to go as well, right?

Addressed all these issues and documented a bit more what each method
does as per Lukas' comments.



Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: command_not_found_cleanup.patch
Type: text/x-patch
Size: 6493 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080403/c2445d2a/attachment.bin 


More information about the bazaar mailing list