[MERGE] "bzr commit" fails with Microsoft FTP Service
Aaron Bentley
aaron at aaronbentley.com
Wed Apr 9 03:36:49 BST 2008
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Andrew Bennetts wrote:
> Andrew Bennetts has voted resubmit.
> Status is now: Resubmit
> Comment:
> I think it should be more like "s.startswith('550')". The patch in its
> current form has a much too large chance of catching other errors.
>
> http://cr.yp.to/ftp/stor.html does say that a 550 response is expected,
> so this seems to be a correct thing to do.
I don't think it's correct to interpret 550 as rename failed. There are
several other things that can cause it. This is why we pay attention to
the strings, not the numerical codes.
Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFH/CvB0F+nu1YWqI0RAjBSAJ0QYHTD7hkHuVyfhlFP6KVtM1LnXQCdFryK
2C4at5gIUffbzEWxmyRx7MI=
=qDWo
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list