[MERGE] "bzr commit" fails with Microsoft FTP Service
Andrew Bennetts
andrew at canonical.com
Wed Apr 9 02:58:19 BST 2008
Andrew Bennetts has voted resubmit.
Status is now: Resubmit
Comment:
I think it should be more like "s.startswith('550')". The patch in its
current form has a much too large chance of catching other errors.
http://cr.yp.to/ftp/stor.html does say that a 550 response is expected,
so this seems to be a correct thing to do.
(Actually, given that responses in FTP can be multiline, including being
preceded by "marks" with 1xx codes, maybe this should be
"s.splitlines()[-1].startswith('550')"?)
For details, see:
http://bundlebuggy.aaronbentley.com/request/%3Cad8e2a1b0804080606q1d22297cpcd938db5bceeb38e%40mail.gmail.com%3E
More information about the bazaar
mailing list