Pending merges

Alexander Belchenko bialix at ukr.net
Wed Apr 2 20:24:33 BST 2008


Aaron Bentley пишет:
> Hi all,
> 
> We've got 33 pending merge requests, 15 of which have been approved or
> conditionally approved.
> 
> This is not a healthy situation.  I would like to see it down to 10 or less.
> 
> If you have had patches approved and have PQM rights, please merge them.
>  Someone made the effort of reviewing your patches on the assumption
> that you *would* merge them, and you owe it to them to do so.  If you do
> not plan on merging them, please mark them "resubmit" or "reject",
> whatever you think is appropriate.
> 
> I have been making an effort to review things, but I am only one man,
> and I am not even one of the people being paid to work on Bazaar.  It's
> depressing to see what happens when I stop reviewing for even one month.
> 
> A little help here, please?

I'm also found this annoying that many patches (especially from core dev guys)
float around approved but not merged.

But I more concerned about patches from people who don't have rights for PQM.
I think 'tweak' for them should be equal to 'resubmit' because one of reviewers
should do such tweaks before merge. I usually try to send merge requests for
cleanly approved patches, but when I see 'tweak' I'm sometimes have no deeper
understanding of required changes.

May we correct our review policy: if patch author is not PQM allowed submitter
then do not vote 'tweak' if reviewer does not have a time to send merge request?

Per example, 
http://bundlebuggy.aaronbentley.com/request/%3C20080317025333.569149d0@lapbert.oxbridgetech%3E
this patch is Conditionally approved. But comments suggesting tweak is better to
will be addressed by patch author. IMO.

What other patch authors think about?



More information about the bazaar mailing list