[MERGE] More deprecations...

Aaron Bentley aaron at aaronbentley.com
Thu Mar 27 17:35:54 GMT 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> On Thu, 2008-03-27 at 16:45 +1100, Andrew Bennetts wrote:
> Firstly, _make_breadth_first_searcher is not private; its just not
> public. We took the stance some time ago that within bzrlib _ is
> advisory for *external users*, not for internal.

Look, I don't remember us taking that stance, and it seems overly
Microsoftian to be using sekret APIs.  If we need the API, someone else
will, too.

> My overall goal here is to get to a VersionedFiles api which is tunable
> to perform well, and doesn't have cruft on it.

That's admirable, but you still haven't responded to my last email about
the namespace issue.

> To do this regardless of conversion approach, we have to stop using the
> old methods that are on 'VersionedFile'. We can do this a number of
> ways: we can leave a thunk permanently in place, we can use external
> functions, we can do basic macro expansion at each current site, or we
> can fix the code up properly.

Aren't you leaving out the option of using an API that delivers
effectively the same data?

AIUI dict(Graph.iter_ancestry(head)) is essentially the same as
get_revision_graph(head).

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFH69r60F+nu1YWqI0RArVuAJwNXmwRryaTvEUCSvDIqpWSsfAqmQCffpu/
A6+M3dkO2qS83nOyH9+Pe0A=
=ydtL
-----END PGP SIGNATURE-----



More information about the bazaar mailing list