[MERGE][Bug #64783] Fixing check to understand the split-up .bzr format

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Daniel Mark Watkins wrote:
> On Mon, 10 Mar 2008 21:21:24 -0400 (EDT)
> Martin Pool <mbp at canonical.com> wrote:
>> You seem to be removing the check.check() api?  That should at least
>> be documented, or better yet left behind and deprecated.
> Done.
> 
>> _get_elements() is useful, though seems like it should be in a more 
>> general location.  Doesn't info do (or need) something very similar? 
>> And I am not so sure it should be checking the paths against '.' in 
>> particular.  If this is factored out it could be tested.
> Done, as bzrdir.open_containing_tree_branch_or_repository.  info can't
> really use the API, but it seems like it could be generally useful so
> I've left it on bzrdir.
> 

BB:tweak

my only complaint is that your:
+    def test_open_containing_tree_branch_or_repository(self):

is testing too much in a single test case. I would ask that you split it
up into testing each case as a separate test case.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFH2p+CJdeBCYSNAAMRAmqKAJ9jSJ0y7L5HnX6C/HgcPEcxa6aKVwCffNIn
tsDhbRmkRYaXz3tiOqGyOKo=
=7+E6
-----END PGP SIGNATURE-----