[MERGE] Merge Check EOL plugin into the core.

[Eugene Wee]

Hi James,

Alexander noted not long after the announcement of this plugin:
 > Different people have different views of this problem.
 > It's actually intermediate solution, and I hope something will be done
 > in real line-endings support.

In fact, the name of the configuration file was originally .checkeol, I 
made the suggestion that Alexander should consider a rename to .bzreol 
precisely because it might be more flexible in the event that a 
line-ending conversion plugin was implemented later.

At this stage, it seems to me that since the configuration file 
specifies the required line-endings for given file extensions, it is 
just a matter of automatically converting for the user instead of 
aborting the commit and informing the user.

However, Martin Pool has suggested that the configuration file format be 
changed. I am not sure if his suggested file format is better though, as 
it states the required line-ending for each file extension, whereas the 
current file format states file extensions for each line-ending, but 
does not look like an ini file so could be less confusing (if it is 
confusing at all).

Regards,
Eugene Wee

James Westby wrote:
> On Tue, 2008-03-11 at 15:32 +0200, Alexander Belchenko wrote:
>> From help topic:
>>
>> 	The 'checkeol' plugin installs special pre-commit hook to Bazaar VCS.
>> 	This hook allows you to check content of committed files for kind
>> 	of line-endings. If your project has strict policy about style of
>> 	source files you could automate EOL check with such plugin.
>> 	If some of committed files will have inappropriate line-endings
>> 	commit will be aborted.
>>
>> Here is the patch to merge this plugin into the core.
> 
> Hi Alexander,
> 
> Thanks for submitting this, I think it would make a valuable addition
> to the core.
> 
> The code looks pretty sane to me, so I don't have any comments on that.
> 
> My only comment would be, does including this prejudice any work that
> may happen in the future to support line endings in a more flexible way?
> For instance, could the .bzreol file specify all that is wanted for 
> that?
> 
> I don't think this should preclude the plugin being merged, I just
> wondered if you had considered the issue.
> 
> Thanks,
> 
> James
> 
> 
>