[MERGE] Merge Check EOL plugin into the core.

James Westby jw+debian at jameswestby.net
Wed Mar 12 04:09:04 GMT 2008


On Tue, 2008-03-11 at 15:32 +0200, Alexander Belchenko wrote:
> From help topic:
> 
> 	The 'checkeol' plugin installs special pre-commit hook to Bazaar VCS.
> 	This hook allows you to check content of committed files for kind
> 	of line-endings. If your project has strict policy about style of
> 	source files you could automate EOL check with such plugin.
> 	If some of committed files will have inappropriate line-endings
> 	commit will be aborted.
> 
> Here is the patch to merge this plugin into the core.

Hi Alexander,

Thanks for submitting this, I think it would make a valuable addition
to the core.

The code looks pretty sane to me, so I don't have any comments on that.

My only comment would be, does including this prejudice any work that
may happen in the future to support line endings in a more flexible way?
For instance, could the .bzreol file specify all that is wanted for 
that?

I don't think this should preclude the plugin being merged, I just
wondered if you had considered the issue.

Thanks,

James





More information about the bazaar mailing list