display of merged revisions in loggerhead and log

Michael Hudson michael.hudson at canonical.com
Tue Mar 11 05:05:17 GMT 2008


Martin Pool wrote:
>> So what do you think of the attached then?
> 
> I like it.

Yay.

> Displaying the branch nick is very good, though I wonder if the
> particular way it is shown here may be taken to mean that eg 3221.1.13
> of "prepare-1.2" was merged, which will not generally be true.

I don't understand this.  In the screenie I posted 
(http://people.ubuntu.com/~mwh/hacked_up_changelog_view_3.png) this 
revision _is_ merged, surely?

> I dislike the different font sizes, and think that just weight and
> color is enough to distinguish them.

Fair enough.

> At the implementation layer, maybe later on the folding could be done
> by inserting blocks that are sent later in the document, so that the
> initial overview appears more quickly.

Hm... maybe.  Let's get a design first, eh? :)

> The 'description' field seems redundant?

Well, the table only contains a short version of the commit message. 
bzr.dev and pqm being what they are, the full version is probably the 
same as the short version here, but in general it's not.

> The 'files' link over on the right seems unclear in purpose.  Does it
> take me to a view of the tree in that revision?  In that case 'tree'
> might be a better name.

Hm, I guess that would be clearer, but it might also be a bit jargon-ish 
for inexperienced people.

 > Also it's unclear what clicking the modified
> files will give.

It takes you to the section of the revision page that contains the diff 
to that file -- which seems reasonable to me.

Cheers,
mwh



More information about the bazaar mailing list