[merge] look for plugins in arch-independent site directory (was Re: Bundling more plugins into bzrtools)

[Alexander Belchenko]

Here is my updated version of Toshio's patch.

Toshio Kuratomi пишет:
> Alexander Belchenko wrote:
>> Alexander Belchenko has voted comment.
>> Status is now: Waiting
>> Comment:
>> I'm not sure that new test 
>> test_set_plugins_path_includes_arch_indep_directory is needed. It 
>> basically repeats the same logic as in real code, so it's not clear 
>> for me why we need it. 
> 
> Yeah, that test would protect against breaking assumptions with a code 
> update (for instance, if new code was committed that removed the 
> arch_indep logic in plugin.py) but it isn't that great.  Ideally we 
> would remove all conditionals from the test.  If you know how to "hide" 
> distutils then a better set of tests would preconstruct the 
> expected_path and check that it gave the right path with distutils 
> available and with it hidden.
> 
>> Also I noticed that old test that failed has their own implementation 
>> for preserving environment variable. It seems for me as thinko 
>> (accroding to abentley). We already have mechanics in TestCase to 
>> automatically clean environment and restore it back after each test.
>> Hm, may be I need to update your patch myself.
>>
> That would be fine with me.  I'm not familiar with the specifics of 
> bzrlib's test suite.
> 
> -Toshio
> 

-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: toshio.patch
Url: https://lists.ubuntu.com/archives/bazaar/attachments/20080302/3e560c9f/attachment.diff