[MERGE] Updates to annotate
John Arbash Meinel
john at arbash-meinel.com
Thu Feb 21 18:42:14 GMT 2008
-----BEGIN PGP SIGNED MESSAGE-----
Robert Collins wrote:
| On Wed, 2008-02-20 at 16:26 -0600, John Arbash Meinel wrote:
|> -----BEGIN PGP SIGNED MESSAGE-----
|> Hash: SHA1
|> The attached patch changes how annotate works. This isn't the last step that
|> I'll be doing to refine annotate, but it does make a significant improvement.
| I don't like the change to get_components_positions - can you enlarge on
| what its for? I'd rather see a new method that does what you need
| without causing more data to be pushed around for things that don't need
| The rest seems fine.
Well, the places that are currently using get_component_positions are actually
using the extra data, I just didn't finish updating them.
Specifically, get_line_list needs to know about newlines and currently has to
re-query the index to find that out after the fact.
It doesn't need the parent_ids, though. But it seemed to make sense to have an
api that gives slightly more info than you need rather than creating 2 apis that
give almost identical values.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
-----END PGP SIGNATURE-----
More information about the bazaar