[MERGE] external_references repository patch.

Andrew Bennetts andrew at canonical.com
Tue Feb 19 22:47:28 GMT 2008


Robert Collins wrote:
> 
> On Tue, 2008-02-19 at 22:13 +1100, Andrew Bennetts wrote:
> > 
> > Oh, right, it's only on RemoteRepository.  Hmm, how about we make
> > _response_is_unknown_method a module-level function?  Then you could
> > use it
> > here.
> 
> Well, not that version, because I don't have a body to cancel :)

Oh, gar.  We could parameterise that, I guess.  Boy it'll be nice when we have a
protocol that makes cancel_read_body unnecessary :)

> Given that there are plenty of instances of these checks to clean up
> still; I'd like to just ignore it in this patch - I'm not making things
> worse, but not better either,

That's fine.

-Andrew.




More information about the bazaar mailing list