Bisect plugin updated

[Robert Collins]

On Mon, 2008-02-18 at 12:43 -0500, Jeff Licquia wrote:
> Robert Collins wrote:
> > I think it would be good to add some queryable metadata to plugins for
> > building a registry of them. To be able to process this with the plugin
> > uninstalled and missing dependencies is desirable (so that you can index
> > a plugin you /can't/ load (such as one for windows only). So I propose
> > some variables put in setup.py as globals - you can import setup.py and
> > query it. And setup.py is the only thing guaranteed importable :). If
> > someone has a buggy setup.py (e.g. one that forgets to do 
> > if __name__ == 'main':
> >    setup stuff here
> > 
> > Then we can file bugs :).
> 
> I've run with this.  Your system should be in bisect now, with some 
> additions.

Cool. I'll do up a patch to bzr to document this.

> > I propose the following variables:
> > The name the plugin expects to be installed under:
> > bzr_plugin_name = 'bisect'
> 
> I've added "bzr_plugin_version", "bzr_minimum_version", and 
> "bzr_maximum_version".  The plugin version should be self-explanatory; 
> minimum and maximum versions refer to the version of bzr the plugin 
> supports, for those plugins that want to do this.  Either or both can be 
> "None".

Rather than bzr_plugin_version can I suggest 'version_info' - which is
what bzr looks for on an installed plugin already. This is a 5-tuple
e.g. (0, 92, 0, 'dev', 0).


> Comments?  In particular, I like the idea of exposing dependencies on 
> bzr versions, but am not entirely satisfied with the implementation.

bzr already exposes an api minimum version - a three-tuple (0, 92, 0)
and a current version 5-tuple. I think that plugins should depend on the
api version they need.

E.g. 'I need 1.2 or later' is a needed api of (1, 2, 0). If the
bzr_minimum_api is greater than this, its not compatible. If the bzr
version itself is less than this, its not compatible.

-Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080219/20a5641f/attachment.pgp