[MERGE] bzr.exe: move builtin plugins out of library.zip to directory 'plugins'

[Robert Collins]

On Mon, 2008-01-21 at 00:57 +0200, Alexander Belchenko wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> This patch finishes reorganization of built-in plugins support for bzr.exe
> that I started before bzr 1.0.
> 
> In my past experiments I found that loading builtin plugins from library.zip
> is slower than from filesystem, because library.zip itself very big
> file (>10MB) with many files inside.
> 
> So I moved builtin plugins (launchpad and multiparent) to 'plugins' directory
> that installed typically as C:\Program Files\Bazaar\plugins.
> bzr.exe is always looking for plugins in this directory, *after* user
> plugins directory (either $APPDATA\bazaar\2.0\plugins or $BZR_PLUGIN_PATH).
> 
> Also I disable looking for plugins in library.zip, therefore it should reduce
> plugins search time as well.
> 
> Now builtin plugins resides in filesystem,
> so user is able disable them, if needed.

I think this is a bad idea; the plugins shipped with bzrlib are in
lockstep with bzr itself, and having them separate on disk allows many
opportunities for problems.

Can we not just have the search be fast because we know exactly how many
plugins are in the .zip ?

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080130/952e9fcc/attachment.pgp