BreadthFirstSearcher and ghosts
Robert Collins
robertc at robertcollins.net
Sun Jan 13 22:34:58 GMT 2008
I have run into a problem with the breadth first searcher and ghosts.
The problem is that it returns ghosts. This is possibly good because we
can then look for them in another repository. OTOH hand it breaks fetch
when you try to find revisions to pull by using a search, because the
ghosts show up as revisions to pull - but are not there.
Now, I can fix this a number of ways:
- make the core parts of 'fetch' (fetch.py in particular) handle a
missing revision as a ghost
- add a flag to breadth first searcher, so that it queries revisions
before returning them. This would also fix a bug where the start
revisions are always returned - even if they are missing. Or we could
just change this without a flag (better I think). My rational for this
is that in stacked situations we stack the parent providers, not the
searcher, and we have no use case for spidering a revision graph *and*
seeing ghosts at the moment.
I'll whip up a patch for the second option now, this mail is to allow
folk to say 'STOP' if needed :).
-Rob
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080114/409f21e9/attachment.pgp
More information about the bazaar
mailing list