[RFC] get_parent_map extra data

[Robert Collins]

On Thu, 2008-01-10 at 20:26 -0500, Aaron Bentley wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Robert Collins wrote:
> > So, one interesting thing is that get_parent_map returns a dict with no
> > entries for missing keys. It would reduce temporary dict pressure in
> > some cases to be able to return extra keys too. As long as clients are
> > iterating their own request list it will always do the right thing.
> > 
> > The only specific use case I have today is
> > RemoteRepository.get_parent_map - we're going to be buffering up 64K or
> > so of parent data in a single round trip; as we walk the parents graph
> > at this point, we could just return the full cached dict each time; this
> > would be slightly cheaper.
> > 
> > Thoughts?
> 
> It sounds like a less friendly interface to me, so I would only do it if
> there was a clear need.  Since RemoteRepository already deals with
> network lag, I don't expect that object allocation time is a significant
> factor.

We have from time to time spent seconds doing local object operations; I
think this is likely to show up in LAN's at some point, but we can defer
it.

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080111/bc741442/attachment.pgp