[RFC] get_parent_map extra data

Aaron Bentley aaron at aaronbentley.com
Fri Jan 11 01:26:19 GMT 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> So, one interesting thing is that get_parent_map returns a dict with no
> entries for missing keys. It would reduce temporary dict pressure in
> some cases to be able to return extra keys too. As long as clients are
> iterating their own request list it will always do the right thing.
> 
> The only specific use case I have today is
> RemoteRepository.get_parent_map - we're going to be buffering up 64K or
> so of parent data in a single round trip; as we walk the parents graph
> at this point, we could just return the full cached dict each time; this
> would be slightly cheaper.
> 
> Thoughts?

It sounds like a less friendly interface to me, so I would only do it if
there was a clear need.  Since RemoteRepository already deals with
network lag, I don't expect that object allocation time is a significant
factor.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHhsW70F+nu1YWqI0RAnA/AJ9zkSFYbhtvVsvexWK/m3HqeVVnbwCfVz/b
0Vgntbuvyvao5ThdVSNoi/M=
=9ggV
-----END PGP SIGNATURE-----



More information about the bazaar mailing list