[MERGE (trunk, 1.1)] fuller deprecation of Graph.get_parents
Robert Collins
robertc at robertcollins.net
Fri Jan 11 01:45:21 GMT 2008
On Thu, 2008-01-10 at 20:20 -0500, Aaron Bentley wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Robert Collins wrote:
> > This is a fuller deprecation of Graph.get_parents.
>
> bb:approve
>
> >
> > Specifically the following two things work which did not in 1.1:
> > - Graph.get_parents will work with a provider that implements
> > get_parent_map only.
> > - Graph.get_parent_map will work with a provider that implements
> > get_parents_only.
>
> You could make this emit a deprecation warning if you like.
I think I'll pass for now :).
> > I deleted the implementations of get_parents on the stock providers as
> > they seem unneeded to me- the API for callers is Graph itself, not the
> > Provider objects - Provider is an implementors interface.
>
> I agree, and had already suggested this.
Cool.
-Rob
--
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20080111/7d4d6ca4/attachment.pgp
More information about the bazaar
mailing list