[MERGE (trunk, 1.1)] fuller deprecation of Graph.get_parents

Aaron Bentley aaron at aaronbentley.com
Fri Jan 11 01:20:40 GMT 2008


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> This is a fuller deprecation of Graph.get_parents.

bb:approve

> 
> Specifically the following two things work which did not in 1.1:
>  - Graph.get_parents will work with a provider that implements 
>    get_parent_map only.
>  - Graph.get_parent_map will work with a provider that implements
>    get_parents_only.

You could make this emit a deprecation warning if you like.

> I deleted the implementations of get_parents on the stock providers as
> they seem unneeded to me- the API for callers is Graph itself, not the
> Provider objects - Provider is an implementors interface.

I agree, and had already suggested this.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFHhsRn0F+nu1YWqI0RAgYRAJ9pdfRbtJ9KVA/0J1GyrW8ARZOHnACfdj+F
V1yefGv/bgEQ+YJj+hLe/bA=
=kVVC
-----END PGP SIGNATURE-----



More information about the bazaar mailing list