[MERGE][bug #175524] Make http test servers 1.1 compliant

Andrew Bennetts andrew at canonical.com
Thu Jan 3 07:38:23 GMT 2008


Vincent Ladeuil wrote:
> HTTP/1.1 was only partially tested, this patch addresses that
> main point and several others found during the work:
[...]
> 
> On the whole, the tests are now more complete and adding an https
> additional parametrization becomes possible.
> 
> There was 236 tests for 'bzr selftest --no-plugins
> tests.test_http', we now have 463 tests, this is due to a
> previously incomplete coverage and some tests now raising N/A
> (where nothing was done before). This also reveals some pycurl
> limitations ;)
> 

bb:tweak

This is a very large diff, but none of the code in it seems particularly gnarly,
and it appears to have good test coverage.  So even though I'm not sure I've
comprehensively read every last detail, I'd be happy to have this merged in
bzr.dev.  It might be good to get Alexander or another Windows user to check it
doesn't cause trouble for them first, but I don't expect any serious problems
there.

I don't have many comments to make:

> +class TestSpecificRequestHandler(http_utils.TestCaseWithWebserver):
> +    """Tests a specific request handler.
> +
> +
> +    Daughter class are expected to override _req_handler_class
> +    """

There's too much vertical whitespace in that docstring.

[...]
> -
> -     def test_empty_pass(self):
> -         raise tests.KnownFailure(
> -             'some versions of pycurl does not handle empty proxy passwords')

Elsewhere you check for the specific versions of pycurl with this bug.  I think
probably this should be a Feature, so affected tests could check that.  I also
wonder if TestNotApplicable would be more appropriate than KnownFailure for this
situation?

-Andrew.




More information about the bazaar mailing list